mbrobbel commented on code in PR #478:
URL: https://github.com/apache/arrow-adbc/pull/478#discussion_r1147312382
##########
rust/src/lib.rs:
##########
@@ -261,6 +261,7 @@ pub trait AdbcStatement {
/// Set the SQL query to execute.
fn set_sql_query(&mut self, query: &str) -> Result<(), AdbcError>;
+ #[cfg(substrait)]
Review Comment:
Maybe it's better to move this method to a subtrait?
```rust
#[cfg(substrait)]
pub trait AdbcConnectionSubstrait: AdbcConnection {
/// Set the Substrait plan to execute.
fn set_substrait_plan(&mut self, plan: substrait::proto::Plan) ->
Result<(), AdbcError>;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
