eerhardt commented on code in PR #34618:
URL: https://github.com/apache/arrow/pull/34618#discussion_r1148226643
##########
csharp/test/Directory.Build.props:
##########
@@ -21,6 +21,7 @@
<PropertyGroup>
<IsPackable>false</IsPackable>
+ <LangVersion>default</LangVersion>
Review Comment:
In https://github.com/apache/arrow/pull/34133 we are moving all the code to
`LangVersion=latest`. Maybe we should just make that change here too, instead
of just changing the test props.
##########
csharp/README.md:
##########
@@ -79,7 +79,7 @@ for currently available features.
- Int8, Int16, Int32, Int64
- UInt8, UInt16, UInt32, UInt64
-- Float, Double
+- Float, Double, Half-float (.NET 6+)
Review Comment:
Can you update
https://github.com/apache/arrow/blob/main/docs/source/status.rst as well?
##########
csharp/src/Apache.Arrow/Arrays/HalfFloatArray.cs:
##########
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+using Apache.Arrow.Types;
+using System;
+
+namespace Apache.Arrow
+{
+ public class HalfFloatArray : PrimitiveArray<Half>
Review Comment:
Do we have `///` doc comments on the other Array types? Can we add a summary
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
