arw2019 commented on a change in pull request #8474:
URL: https://github.com/apache/arrow/pull/8474#discussion_r529918880
##########
File path: cpp/src/arrow/util/bit_block_counter.h
##########
@@ -244,6 +244,30 @@ class ARROW_EXPORT OptionalBinaryBitBlockCounter {
}
}
+ BitBlockCount NextOrNotBlock() {
Review comment:
I'm duplicating code here. `NextOrBlock` is identical to
https://github.com/apache/arrow/blob/bd107272c076687212720a10514e7698eff25ffe/cpp/src/arrow/util/bit_block_counter.h#L223-L231
except for `case HasBitmap::BOTH:` where `NextOrNotWord` is called. Is there
a good way to avoid the repetition?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
