ozankabak commented on code in PR #5661:
URL: https://github.com/apache/arrow-datafusion/pull/5661#discussion_r1148425099
##########
datafusion/core/src/physical_plan/joins/symmetric_hash_join.rs:
##########
@@ -399,10 +393,14 @@ impl ExecutionPlan for SymmetricHashJoinExec {
self.schema.clone()
}
- fn required_input_ordering(&self) -> Vec<Option<&[PhysicalSortExpr]>> {
+ fn required_input_ordering(&self) ->
Vec<Option<Vec<PhysicalSortRequirement>>> {
Review Comment:
I think you mean something like:
```rust
type Ordering = Vec<PhysicalSortExpr>;
type OrderingRequirement = Vec<PhysicalSortRequirement>;
```
and which would allow us increase readability by changing
```rust
impl ExecutionPlan {
fn required_input_ordering(&self) ->
Vec<Option<Vec<PhysicalSortRequirement>>>;
fn output_ordering(&self) -> Option<&[PhysicalSortExpr]>;
}
```
to
```rust
impl ExecutionPlan {
fn required_input_ordering(&self) -> Vec<Option<OrderingRequirement>>;
fn output_ordering(&self) -> Option<Ordering>;
}
```
Am I understanding your idea right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
