tustvold commented on code in PR #3945:
URL: https://github.com/apache/arrow-rs/pull/3945#discussion_r1148451758
##########
arrow-arith/src/arithmetic.rs:
##########
@@ -3402,4 +3454,30 @@ mod tests {
.to_string()
.contains("Required scale 5 is greater than product scale 4"));
}
+
Review Comment:
Could we perhaps get a test where `multiply_fixed_point` doesn't overflow as
result of the scale reduction? i.e. to show how it differs from just doing
`multiply` followed by `divide`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
