tustvold commented on code in PR #3950:
URL: https://github.com/apache/arrow-rs/pull/3950#discussion_r1148582761
##########
arrow-buffer/src/bigint.rs:
##########
@@ -40,6 +59,67 @@ impl std::fmt::Display for i256 {
}
}
+impl FromStr for i256 {
+ type Err = ParseI256Error;
+
+ fn from_str(s: &str) -> Result<Self, Self::Err> {
+ // i128 can store up to 38 decimal digits
+ if s.len() <= 38 {
+ return Ok(Self::from_i128(i128::from_str(s)?));
Review Comment:
Potentially, I didn't for now as it would entail adding a dependency to
arrow_buffer, definitely something to consider should i256 parsing performance
become a bottleneck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
