viirya commented on code in PR #5675:
URL: https://github.com/apache/arrow-datafusion/pull/5675#discussion_r1148798935
##########
datafusion/core/tests/sqllogictests/src/engines/conversion.rs:
##########
@@ -74,9 +74,9 @@ pub fn f64_to_str(value: f64) -> String {
}
}
-pub fn i128_to_str(value: i128, scale: u32) -> String {
+pub fn i128_to_str(value: i128, precision: &u8, scale: &i8) -> String {
big_decimal_to_str(
- BigDecimal::from_str(&Decimal::from_i128_with_scale(value,
scale).to_string())
Review Comment:
`rust-decimal` doesn't allow precision > 28. We can simply use
`Decimal128Type` from arrow-rs to get string of decimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
