[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #5661: Top down `EnforceSorting`, Extended testbench for `EnforceSorting` rule to prepare for refactors, additional functionality such as pushdowns over unions

Mon, 27 Mar 2023 00:31:28 -0700 


mustafasrepo commented on code in PR #5661:
URL: https://github.com/apache/arrow-datafusion/pull/5661#discussion_r1148897126


##########
datafusion/core/src/physical_optimizer/dist_enforcement.rs:
##########
@@ -2104,7 +2080,6 @@ mod tests {
         // The optimizer should not add an additional SortExec as the
         // data is already sorted
         let expected = &[

Review Comment:
   Thanks for pointing this out. I have converted input source to 
`parquet_exec_multiple_sorted` test now keeps `SortPreservingMergeExec`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to