wjones127 commented on PR #34697: URL: https://github.com/apache/arrow/pull/34697#issuecomment-1485387051
> as RUN_END_ENCODED is a new type, we could add this layout validation in this switch without breaking existing code as REEs are not used yet. This is our chance :-) So we have added an equivalent check to this within the REE array path: https://github.com/apache/arrow/blob/4a0fc2868cbb7c2e78f76855ad476c260b92b495/cpp/src/arrow/array/validate.cc#L648-L650 My questions is whether we should enable this for other arrays that have always null buffers, such as NullArray and UnionArray. It seems we don't enforce this for these other types right now in validate, and I'd rather not change that in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
