alamb commented on code in PR #5625:
URL: https://github.com/apache/arrow-datafusion/pull/5625#discussion_r1149733225
##########
datafusion/common/Cargo.toml:
##########
@@ -44,10 +44,12 @@ arrow = { workspace = true, default-features = false }
arrow-array = { version = "35.0.0", default-features = false, features =
["chrono-tz"] }
chrono = { version = "0.4", default-features = false }
cranelift-module = { version = "0.92.0", optional = true }
+lazy_static = "1.4.0"
Review Comment:
I think these are already dependencies of other datafusion crates so this
doesn't increase our overall dependency footprint
##########
datafusion/common/src/column.rs:
##########
@@ -112,12 +115,21 @@ impl Column {
/// Serialize column into a quoted flat name string
pub fn quoted_flat_name(&self) -> String {
- // TODO: quote identifiers only when special characters present
- // see: https://github.com/apache/arrow-datafusion/issues/5523
match &self.relation {
Some(r) => {
- format!("{}.{}", r.to_quoted_string(),
quote_identifier(&self.name))
+ lazy_static! {
+ static ref CAPTURE_VALID_RE: Regex =
Review Comment:
This seems like we could do this via a combination of
https://doc.rust-lang.org/std/primitive.char.html#method.is_ascii_digit
https://doc.rust-lang.org/std/primitive.char.html#method.is_ascii_lowercase
https://doc.rust-lang.org/std/primitive.char.html#method.is_ascii_uppercase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
