wjones127 commented on code in PR #34355:
URL: https://github.com/apache/arrow/pull/34355#discussion_r1149809972
##########
cpp/src/parquet/statistics.cc:
##########
@@ -495,9 +495,12 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
bool has_null_count, bool has_distinct_count,
MemoryPool* pool)
: TypedStatisticsImpl(descr, pool) {
TypedStatisticsImpl::IncrementNumValues(num_values);
+ // Currently, `has_null_count` argument is not used.
+ // Internal has_null_count_ would always be true.
Review Comment:
IIUC, this class is only used in the writer and we always write the null
count in statistics? If so, then I agree we can remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
