westonpace commented on code in PR #34711:
URL: https://github.com/apache/arrow/pull/34711#discussion_r1149885719
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -405,6 +404,14 @@ takes precedence over ccache if a storage backend is
configured" ON)
ARROW_IPC
ARROW_PARQUET)
+ define_option(ARROW_ACERO
+ "Build the Arrow Acero Engine Module"
+ OFF
+ DEPENDS
+ ARROW_COMPUTE
+ ARROW_IPC
+ ARROW_PARQUET)
Review Comment:
Why do we depend on IPC and parquet here? Is it just for testing I wonder?
I think it's probably ok but I didn't have that dependency in my mind.
##########
python/pyarrow/acero.py:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+from pyarrow._acero import ( # noqa
Review Comment:
@jorisvandenbossche any opinion on this moving here? It looks like this
came from `test_acero.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
