dinimar commented on code in PR #34537:
URL: https://github.com/apache/arrow/pull/34537#discussion_r1150126607
##########
cpp/src/arrow/type_test.cc:
##########
@@ -398,6 +563,71 @@ TEST(TestFieldRef, Basics) {
EXPECT_THAT(FieldRef("beta").FindAll(s), ElementsAre(FieldPath{1},
FieldPath{3}));
}
+TEST(TestFieldRef, FindAllForTable) {
Review Comment:
In my opinion, it seems ok that we have test cases for `FindAll` function
for specific types.
The question is about the coverage. So, if @zeroshade @westonpace agree with
these test cases removal I'll do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
