thisisnic commented on code in PR #34708:
URL: https://github.com/apache/arrow/pull/34708#discussion_r1150722399


##########
r/R/io.R:
##########
@@ -239,6 +239,14 @@ make_readable_file <- function(file, mmap = TRUE) {
     path <- sub("/$", "", file$base_path)
     file <- filesystem$OpenInputFile(path)
   } else if (is.string(file)) {
+
+    # if this is a HTTP URL, we need a local copy to pass to 
FileSystem$from_uri
+    if (is_http_url(file)) {
+        tf <- tempfile()

Review Comment:
   I've just moved it up a level, so we do this in the body of `read_parquet()` 
instead of `make_readable_file()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to