thinkharderdev commented on code in PR #728: URL: https://github.com/apache/arrow-ballista/pull/728#discussion_r1150844439
########## ballista/scheduler/src/state/executor_manager.rs: ########## Review Comment: So this removes the local in-memory cache of heartbeats which is there to avoid having to fetch them from shared state. This is indeed redundant in the case where you are using fully in-memory state but not if you are using shared state across multiple executors. For example, we use redis for managing the cluster state and use pub/sub channels to propagate heartbeats to all executors so we don't have to constantly fetch them from redis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
