xhochy commented on a change in pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#discussion_r530373157



##########
File path: cpp/cmake_modules/DefineOptions.cmake
##########
@@ -363,6 +363,8 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL 
"${CMAKE_CURRENT_SOURCE_DIR}")
 
   define_option(ARROW_WITH_UTF8PROC
                 "Build with support for Unicode properties using the utf8proc 
library" ON)
+  define_option(ARROW_WITH_RE2
+                "Build with support for regular expressions using the re2 
library" ON)

Review comment:
       This is sadly the prettiest solution I can think of at the moment. You 
can define conditional options in CMake but they only make sense based on 
attributes that are not set by the user but the environment (e.g. which 
operating system). 
   
   I'll add a comment to this and the above option explaining that they are 
only used in certain situations.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to