tustvold commented on code in PR #3973:
URL: https://github.com/apache/arrow-rs/pull/3973#discussion_r1151761465


##########
object_store/src/lib.rs:
##########
@@ -371,11 +371,33 @@ pub trait ObjectStore: std::fmt::Display + Send + Sync + 
Debug + 'static {
     ///
     /// Prefixes are evaluated on a path segment basis, i.e. `foo/bar/` is a 
prefix of `foo/bar/x` but not of
     /// `foo/bar_baz/x`.
+    ///
+    /// Note: the order of returned [`ObjectMeta`] is not guaranteed

Review Comment:
   I had a brief play, this is hard to implement on a filesystem as 
lexicographic sorting doesn't group "directories" together. Consider the case 
of `a a/b.file` and `a/a/b.file`, a true lexicographic sort would be as 
presented, but a lexicographic sort of directories would not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to