paleolimbot commented on code in PR #175:
URL: https://github.com/apache/arrow-nanoarrow/pull/175#discussion_r1152051232
##########
src/nanoarrow/nanoarrow_types.h:
##########
@@ -319,6 +319,25 @@ enum ArrowTimeUnit {
NANOARROW_TIME_UNIT_NANO = 3
};
+/// \brief Validation level enumerator
+/// \ingroup nanoarrow-array
+enum ArrowValidationLevel {
+ /// \brief Do not validate buffer sizes or content.
+ NANOARROW_VALIDATION_LEVEL_NONE = 0,
+
+ /// \brief Validate buffer sizes that depend on array length but do not
validate buffer
+ /// sizes that depend on buffer data access.
Review Comment:
Yes, we don't access buffers with "minimal" validation. I added a basic test
for this, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
