maartenbreddels commented on pull request #8459: URL: https://github.com/apache/arrow/pull/8459#issuecomment-733739638
There are two issues with this PR: ## empty slices In #8728 https://github.com/apache/arrow/pull/8728/files#diff-7771ecc138c4ecc2dc8498affe04f5b7f182c4b77b18a512c3dd07a82d45aa3dR116 was added, which adds an empty slice to the test, which breaks my test (which is good). However, my kernel will not be called, meaning i cannot set the output's type (which depends on the input regex). Shall I open a JIRA for that? The error is: ``` # Array types differed: struct<letter: string, digit: string> vs struct<> Null counts differ. Expected -1 but was 0 Expected: -- is_valid: all not null -- child 0 type: string [] -- child 1 type: string [] Actual: -- is_valid: all not null ``` (showing the struct mismatch) ## ChunkedArray fails Commenting out the empty slice test, the next failure is with https://github.com/apache/arrow/blob/db20c7a611adac7be5cdd9350792852345f5b6b4/cpp/src/arrow/compute/kernels/test_util.cc#L133 ``` Failed Got: [ -- is_valid: all not null -- child 0 type: string [ "a" ] -- child 1 type: string [ "1" ], -- is_valid: [ true, false, false ] -- child 0 type: string [ "b", "", "" ] -- child 1 type: string [ "2", "", "" ] ] Expected: [ -- is_valid: all not null -- child 0 type: string [ "a" ] -- child 1 type: string [ "1" ], -- is_valid: [ true, false, false ] -- child 0 type: string [ "b", "", "" ] -- child 1 type: string [ "2", "", "" ] ] ``` I fail to see a difference in this output (maybe a null value in a child?), and this is difficult to debug in gdb. Maybe an opportunity to improve the printing of differences (since I fail to see any). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
