milevin commented on PR #5748: URL: https://github.com/apache/arrow-datafusion/pull/5748#issuecomment-1488998347
> > The analyzer is assigning incorrect nullability flags to the right side of the join. I wonder if we shouldn't fix this inst > > I believe the story is that @comphead plans to fix this in a follow on PR. Is that accurate @comphead ? @alamb This comment of mine was on an original version of this PR which tried to address the issue by weakening the compatibility check; @comphead followed the suggestion in the comment to rewrite the fix by changing the analyzer instead -- so all is good! Note: for the case of LEFT join, the right side must be nullified (that's what the comment talks about). A follow on PR will handle RIGHT and OUTER join where the left side will have to be adjusted as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
