comphead commented on code in PR #5769:
URL: https://github.com/apache/arrow-datafusion/pull/5769#discussion_r1152291596
##########
datafusion/core/tests/sqllogictests/src/engines/datafusion/normalize.rs:
##########
@@ -36,7 +35,7 @@ pub fn convert_batches(batches: Vec<RecordBatch>) ->
Result<Vec<Vec<String>>> {
let mut rows = vec![];
for batch in batches {
// Verify schema
- if !equivalent_names_and_types(&schema, batch.schema()) {
+ if !schema.contains(&batch.schema()) {
Review Comment:
Thanks for checking. It is stricter thats correct but in the same time it
has more weak rules for nullability checks which work for us now.
```
// self need to be nullable or both of them are not nullable
&& (self.nullable || !other.nullable)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
