tustvold commented on code in PR #3965:
URL: https://github.com/apache/arrow-rs/pull/3965#discussion_r1152533153
##########
arrow-integration-test/src/schema.rs:
##########
@@ -178,10 +181,10 @@ mod tests {
),
Field::new(
"c25",
- DataType::Struct(vec![
+ DataType::Struct(Fields::from(vec![
Review Comment:
I'm not convinced by this, the major reason for using the more verbose
`DataType::Struct(Fields::from(..))` was to reduce formatting churn, most
downstreams will just be able to use `.into()`.
I'll have a go upgrading DataFusion to assess the churn required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
