assignUser commented on code in PR #169:
URL: https://github.com/apache/arrow-nanoarrow/pull/169#discussion_r1152607329
##########
extensions/nanoarrow_ipc/CMakeLists.txt:
##########
@@ -16,9 +16,13 @@
# under the License.
message(STATUS "Building using CMake version: ${CMAKE_VERSION}")
-cmake_minimum_required(VERSION 3.11)
+cmake_minimum_required(VERSION 3.14)
include(FetchContent)
+if(NOT DEFINED CMAKE_C_STANDARD)
+ set(CMAKE_C_STANDARD 11)
Review Comment:
Fun fact, this actually does not enforce the usage of C11 but allows a
compiler to decay to an earlier version.
See https://cmake.org/cmake/help/latest/prop_tgt/C_STANDARD_REQUIRED.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
