youngsofun commented on code in PR #3948:
URL: https://github.com/apache/arrow-rs/pull/3948#discussion_r1152687843
##########
arrow-flight/src/sql/client.rs:
##########
@@ -223,6 +223,47 @@ impl FlightSqlServiceClient {
.into_inner())
}
+ /// Push a stream to the flight service associated with a particular
flight stream.
+ pub async fn do_put(
+ &mut self,
+ request: impl tonic::IntoStreamingRequest<Message = FlightData>,
+ ) -> Result<Streaming<PutResult>, ArrowError> {
+ let req = self.set_request_headers(request.into_streaming_request())?;
+ Ok(self
+ .flight_client
+ .do_put(req)
+ .await
+ .map_err(status_to_arrow_error)?
+ .into_inner())
+ }
+
+ /// DoAction allows a flight client to do a specific action against a
flight service
+ pub async fn do_action(
+ &mut self,
+ request: impl IntoRequest<Action>,
Review Comment:
I have refactored it to be consistent in the other way: all use `impl
IntoRequest`.
1. do make the life of the caller easier.
2. consistent with the API of FlightClient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
