AlenkaF commented on PR #8510:
URL: https://github.com/apache/arrow/pull/8510#issuecomment-1490120045

   One more thing connected to the CMake part of the code. To make the headers 
available for usage in other languages, I suggest this diff to be added:
   
   ```diff
   diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
   index 9df85ce303..60eb1115f3 100644
   --- a/cpp/src/arrow/CMakeLists.txt
   +++ b/cpp/src/arrow/CMakeLists.txt
   @@ -888,6 +888,7 @@ endif()
    
    if(ARROW_JSON)
      add_subdirectory(json)
   +  add_subdirectory(extension)
    endif()
    
    if(ARROW_ORC)
   diff --git a/cpp/src/arrow/extension/CMakeLists.txt 
b/cpp/src/arrow/extension/CMakeLists.txt
   new file mode 100644
   index 0000000000..c15c42874d
   --- /dev/null
   +++ b/cpp/src/arrow/extension/CMakeLists.txt
   @@ -0,0 +1,24 @@
   +# Licensed to the Apache Software Foundation (ASF) under one
   +# or more contributor license agreements.  See the NOTICE file
   +# distributed with this work for additional information
   +# regarding copyright ownership.  The ASF licenses this file
   +# to you under the Apache License, Version 2.0 (the
   +# "License"); you may not use this file except in compliance
   +# with the License.  You may obtain a copy of the License at
   +#
   +#   http://www.apache.org/licenses/LICENSE-2.0
   +#
   +# Unless required by applicable law or agreed to in writing,
   +# software distributed under the License is distributed on an
   +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   +# KIND, either express or implied.  See the License for the
   +# specific language governing permissions and limitations
   +# under the License.
   +
   +add_arrow_test(test
   +               SOURCES
   +               fixed_shape_tensor_test.cc
   +               PREFIX
   +               "arrow-fixed-shape-tensor")
   +
   +arrow_install_all_headers("arrow/extension")
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to