icexelloss commented on code in PR #34777: URL: https://github.com/apache/arrow/pull/34777#discussion_r1153375391
########## cpp/src/arrow/engine/substrait/relation_internal.cc: ########## @@ -89,7 +89,7 @@ Result<EmitInfo> GetEmitInfo(const RelMessage& rel, } emit_info.expressions = std::move(proj_field_refs); emit_info.schema = schema(std::move(emit_fields)); - return std::move(emit_info); Review Comment: I don't think std::move of return value is good practice. (Since this prevents NRVO) so I removed them here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
