yahoNanJing commented on code in PR #728:
URL: https://github.com/apache/arrow-ballista/pull/728#discussion_r1153420565
##########
ballista/scheduler/src/cluster/kv.rs:
##########
@@ -57,6 +56,8 @@ pub struct KeyValueState<
> {
/// Underlying `KeyValueStore`
store: S,
+ /// ExecutorHeartbeat cache, executor_id -> ExecutorHeartbeat
+ executor_heartbeats: Arc<DashMap<String, ExecutorHeartbeat>>,
Review Comment:
If the multiple active schedulers is required, I think your current design
of `ExecutionReservation` is reasonable. And the consistent hashing based task
assignments may be only possible for the single active scheduler without slots
contention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
