viirya commented on code in PR #5807:
URL: https://github.com/apache/arrow-datafusion/pull/5807#discussion_r1153816981
##########
datafusion/sql/tests/integration_test.rs:
##########
@@ -2905,8 +2886,8 @@ fn aggregate_with_cube() {
#[test]
fn round_decimal() {
- let sql = "SELECT round(price/3, 2) FROM test_decimal";
- let expected = "Projection: round(test_decimal.price / Int64(3), Int64(2))\
+ let sql = "SELECT round(price/3, CAST(2 AS INT)) FROM test_decimal";
+ let expected = "Projection: round(test_decimal.price / Int64(3),
CAST(Int64(2) AS Int32))\
\n TableScan: test_decimal";
quick_test(sql, expected);
}
Review Comment:
In this file, I only manually change this test.
##########
datafusion/sql/tests/integration_test.rs:
##########
@@ -2905,8 +2886,8 @@ fn aggregate_with_cube() {
#[test]
fn round_decimal() {
- let sql = "SELECT round(price/3, 2) FROM test_decimal";
- let expected = "Projection: round(test_decimal.price / Int64(3), Int64(2))\
+ let sql = "SELECT round(price/3, CAST(2 AS INT)) FROM test_decimal";
+ let expected = "Projection: round(test_decimal.price / Int64(3),
CAST(Int64(2) AS Int32))\
\n TableScan: test_decimal";
quick_test(sql, expected);
}
Review Comment:
In this file, I only manually changed this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
