mapleFU commented on code in PR #34632:
URL: https://github.com/apache/arrow/pull/34632#discussion_r1154029650
##########
cpp/src/parquet/encoding.cc:
##########
@@ -2107,9 +2107,12 @@ class DictByteArrayDecoderImpl : public
DictDecoderImpl<ByteArrayType>,
template <typename DType>
class DeltaBitPackEncoder : public EncoderImpl, virtual public
TypedEncoder<DType> {
+ static_assert(std::is_same_v<int32_t, typename DType::c_type> ||
+ std::is_same_v<int64_t, typename DType::c_type>);
// Maximum possible header size
static constexpr uint32_t kMaxPageHeaderWriterSize = 32;
- static constexpr uint32_t kValuesPerBlock = 128;
+ static constexpr uint32_t kValuesPerBlock =
+ std::is_same_v<int32_t, typename DType::c_type> ? 128 : 256;
static constexpr uint32_t kMiniBlocksPerBlock = 4;
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
