rok commented on code in PR #8510: URL: https://github.com/apache/arrow/pull/8510#discussion_r1154391217
########## cpp/src/arrow/CMakeLists.txt: ########## @@ -805,6 +806,10 @@ if(ARROW_IPC) add_arrow_test(extension_type_test) endif() +if(ARROW_JSON) + add_arrow_test(canonical_extension_test SOURCES extension/fixed_shape_tensor_test.cc) Review Comment: `add_definitions(-DARROW_JSON)` won't do it as it redefines a flag. See [here](https://github.com/apache/arrow/actions/runs/4574717127/jobs/8076673684?pr=8510#step:11:1247). I'll revert to `ARROW_WITH_JSON` but I'm still open to other options. Also not we use `ARROW_WITH_X` in several places so this would not be that inconsistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
