mingmwang commented on code in PR #5770:
URL: https://github.com/apache/arrow-datafusion/pull/5770#discussion_r1154391387
##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -952,21 +952,21 @@ impl DefaultPhysicalPlanner {
let join_filter = match filter {
Some(expr) => {
- // Extract columns from filter expression
+ // Extract columns from filter expression and
saved in a HashSet
let cols = expr.to_columns()?;
- // Collect left & right field indices
+ // Collect left & right field indices, the field
indices are sorted in ascending order
Review Comment:
Sure, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
