jorisvandenbossche commented on code in PR #8510: URL: https://github.com/apache/arrow/pull/8510#discussion_r1154453696
########## cpp/src/arrow/CMakeLists.txt: ########## @@ -805,6 +806,10 @@ if(ARROW_IPC) add_arrow_test(extension_type_test) endif() +if(ARROW_JSON) + add_arrow_test(canonical_extension_test SOURCES extension/fixed_shape_tensor_test.cc) Review Comment: Strange thing is that we are already using `#ifdef ARROW_JSON` elsewhere: https://github.com/apache/arrow/blob/8efb43ddcb908747c64cc5048930209305bcdc73/cpp/src/arrow/public_api_test.cc#L50 > `add_definitions(-DARROW_JSON)` won't do it as it redefines a flag. Ah, because we already have it in `config.h.cmake`. But then indeed it should already work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
