paleolimbot commented on code in PR #34708:
URL: https://github.com/apache/arrow/pull/34708#discussion_r1154511236
##########
r/R/io.R:
##########
@@ -239,6 +239,14 @@ make_readable_file <- function(file, mmap = TRUE) {
path <- sub("/$", "", file$base_path)
file <- filesystem$OpenInputFile(path)
} else if (is.string(file)) {
+
+ # if this is a HTTP URL, we need a local copy to pass to
FileSystem$from_uri
+ if (is_http_url(file)) {
+ tf <- tempfile()
Review Comment:
I think we probably do want to do this in `make_readable_file()` because
then this will work for Arrow files as well. It's useful in other contexts to
specifically *avoid* making a random access file, too (e.g.,
https://github.com/apache/arrow/issues/34779 )...I think the right solution
here is to make `make_readable_file()` aware of whether the result should or
should not be a `RandomAccessFile` or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
