alamb commented on code in PR #3953:
URL: https://github.com/apache/arrow-rs/pull/3953#discussion_r1154551244
##########
arrow-array/src/record_batch.rs:
##########
@@ -447,23 +447,28 @@ impl Default for RecordBatchOptions {
Self::new()
}
}
+impl From<StructArray> for RecordBatch {
+ fn from(value: StructArray) -> Self {
+ assert_eq!(
+ value.null_count(),
+ 0,
+ "Cannot convert nullable StructArray to RecordBatch"
Review Comment:
> I think I'm missing something as to why this is a controversial change?
My understanding is that it makes something that used to work panic. Maybe
my problem is that I don't really understand the problem this is fixing
(https://github.com/apache/arrow-rs/issues/3952 just says that something should
work, not the why). It is probably obvious to you but sadly it is not obvious
to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
