berkaysynnada commented on PR #5764: URL: https://github.com/apache/arrow-datafusion/pull/5764#issuecomment-1492214820
> Thank you @berkaysynnada 🙇 . I think this issue: > > > removing the arithmetic code to binary.rs > > This is the most valuable part in my opinion as it pays down tech debt and sets us up for a easier migration / porting of the code upstream to arrow-rs -- and since you probably still have all the timestamp / kernel context in your head, you are probably likely to do it more quickly than someone who needs to get up to speed I am working on symmetric hash join with temporal type inputs, and hence I need to modify `evaluate_array` function in datetime.rs, where the evaluations of Array vs. Scalar values are done (newly added match arms here also use some of these arithmetic functions). I plan to insert that removal work to sym hash join PR, if it is not a problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
