icexelloss commented on PR #34711: URL: https://github.com/apache/arrow/pull/34711#issuecomment-1492415729
> What is the relationship between arrow_substrait and arrow_acero? Part of me wonders why substrait makes sense as a separate library rather than optional feature of acero? Originally the plan is to have substrait to be a part of acero. This doesn't currently work because substrait needs dataset to support some of the ReadRel. @westonpace @ildipo and I have talked about move substrait into acero and allow dataset to register substrait rule for the ReadRel stuff but decided it's best not to mix that into this PR. > Also, the acerointernal namespace change seems unnecessary since it's already scoped within acero. I agree this seems unnessary and will make a shot to do what you suggested (use internal instead of acerointernal) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
