romainfrancois commented on pull request #8650: URL: https://github.com/apache/arrow/pull/8650#issuecomment-734746906
This is still quite wip, as I navigate how the various `Converter` work together. It all feels a bit weird to operate in terms of single values, i.e. via the `Append()` methods, since R does not have such concept, this has to resort to many casting. It feels particularly odd with the struct converter (converting from a data frame). As of right now, this is bypassing `Append()` and instead uses a `Visit()` method that appends several (column by column). Would it make sense to have some sort of vectorised approach ? Should this instead figure out a way to treat data frames that the struct array gets built row by row instead of column by column ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
