westonpace commented on code in PR #34711: URL: https://github.com/apache/arrow/pull/34711#discussion_r1154857322
########## cpp/src/arrow/acero/asof_join_node.h: ########## @@ -36,11 +36,11 @@ using AsofJoinKeys = AsofJoinNodeOptions::Keys; /// \param[in] input_schema the schema of each input to the node /// \param[in] input_keys the key of each input to the node /// \param[out] field_output_indices the output index of each field -ARROW_EXPORT Result<std::shared_ptr<Schema>> MakeOutputSchema( +ARROW_ACERO_EXPORT Result<std::shared_ptr<Schema>> MakeOutputSchema( Review Comment: If we have `ARROW_ACERO` and `ARROW_ENGINE` (or later, `ARROW_SUBSTRAIT`) then we should have exports for both, mostly for consistency (every module has its own export macro). To be honest, I don't really know why we can't just have `ARROW_EXPORT` everywhere. I think it allows for building a module but not exporting its symbols but I don't know why we would want to do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
