izveigor commented on code in PR #5816:
URL: https://github.com/apache/arrow-datafusion/pull/5816#discussion_r1155114869
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1072,6 +1072,18 @@ impl<'a, S: SimplifyInfo> TreeNodeRewriter for
Simplifier<'a, S> {
out_expr.rewrite(self)?
}
+ // log
Review Comment:
I think this file is too large. Should we split the file into several by
their expressions (for example: scalar_function.rs, bitwise_operations.rs ...)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
