zhzy0077 commented on PR #5811: URL: https://github.com/apache/arrow-datafusion/pull/5811#issuecomment-1493245241
> Thank you @zhzy0077 -- this looks like a great improvement to me > > Can you also please add a test that ensures the overflow behavior is consistent with the arrow compute kernels (I can't remember if they error on overflow). Perhaps following the model of: > > https://github.com/apache/arrow-datafusion/blob/ab2ad35e821e754c5ba20e92da0f6cacf205b831/datafusion/common/src/scalar.rs#L4896-L4913 Thank you. Added a few tests in `scalar_add_overflow_test`. Not sure if this covers all your concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
