yjshen commented on PR #5837:
URL:
https://github.com/apache/arrow-datafusion/pull/5837#issuecomment-1493980630
I understand the collapsing rule as it removes the requirement of creating a
RecordBatch from states and then reading them back for final evaluation.
As for naming this new aggregation mode, I find `Complete` more descriptive
when displayed as output, but I have no strong preference.
```scala
ProjectionExec: expr=[l_partkey@0 as l_partkey, ....
AggregateExec: mode=Single...
ParquetExec ...
```
```scala
ProjectionExec: expr=[l_partkey@0 as l_partkey, ...
AggregateExec: mode=Complete...
ParquetExec ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
