avantgardnerio commented on code in PR #5835:
URL: https://github.com/apache/arrow-datafusion/pull/5835#discussion_r1156012986
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1490,6 +1490,8 @@ pub struct Union {
pub struct CreateMemoryTable {
/// The table name
pub name: OwnedTableReference,
+ /// The ordered list of columns in the primary key, or an empty vector if
none
+ pub primary_key: Vec<Column>,
Review Comment:
I did some research: sqlparser is correct in this case, as `CreateTable` has
columns that define the `unique constraint` that is the `primary key`.
Constraints don't have ordering, indexes do.
I assume that if the users does a `create index` we will receive information
about sort order of each column, but either way it's proper not to have it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]