alamb commented on code in PR #5819:
URL: https://github.com/apache/arrow-datafusion/pull/5819#discussion_r1156145218
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -2320,16 +2337,10 @@ mod tests {
assert_no_change(regex_match(col("c1"), lit("f_o")));
// empty cases
- assert_change(regex_match(col("c1"), lit("")), like(col("c1"), "%"));
Review Comment:
I double checked that datafusion got the right answer, both before and after
this PR:
```shell
❯ select regexp_match('foo', '');
+-----------------------------------+
| regexpmatch(Utf8("foo"),Utf8("")) |
+-----------------------------------+
| [] |
+-----------------------------------+
1 row in set. Query took 0.000 seconds.
```
So things look ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
