r4ntix commented on PR #5732: URL: https://github.com/apache/arrow-datafusion/pull/5732#issuecomment-1495280662
> Thanks @r4ntix -- I think this looks good to me. Thank you for moving the code. > > I had some small documentation suggestions. > > My biggest concern / question is about testing -- specifically do you think it is worth writing tests (especially for error conditions) for `options`? I am mostly worried about potentially breaking this functionality with some future refactor but not catching that because of lack fo test coverage @alamb Thank you very much for your very detailed advice! About tests, I will add `Unit tests` for this first. Secondly, I am currently considering whether we can add `Integration Tests`, e.g. emulator tests of `arrow-rs/object_store`, but this may take extra time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
