nevi-me commented on a change in pull request #8790:
URL: https://github.com/apache/arrow/pull/8790#discussion_r532035226
##########
File path: rust/parquet/src/arrow/arrow_writer.rs
##########
@@ -665,6 +670,16 @@ where
values
}
+fn get_bool_array_slice(array: &arrow_array::BooleanArray) -> Vec<bool> {
+ let mut values = Vec::with_capacity(array.len() - array.null_count());
Review comment:
The logic that we were using was incorrect (at least once we get to
lists). #8792 fixes this, so if it gets merged first, we would need to change
this to populate values correctly .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
