alamb commented on a change in pull request #8788:
URL: https://github.com/apache/arrow/pull/8788#discussion_r532035806
##########
File path: rust/arrow/src/json/reader.rs
##########
@@ -1559,6 +1608,54 @@ mod tests {
}
}
+ #[test]
+ fn test_nested_struct_json_arrays() {
Review comment:
This is a pretty cool test case demonstrating what is going on -- TIL I
learn that we have a JSON schema extractor in arrow!
##########
File path: rust/arrow/test/data/nested_structs.json
##########
@@ -0,0 +1,4 @@
+{"a": {"b": true, "c": {"d": "text"}}}
Review comment:
Given the size of this file (very small) I wonder if the test case
itself would be more readable if the contents were inlined directly into the
rust source code. I don't see any issues with it being in its own file, this is
more a style comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
