thisisnic commented on PR #34825: URL: https://github.com/apache/arrow/pull/34825#issuecomment-1496265923
Thanks folks for the discussion here, it's good to have more eyes on this. > If I remember correctly, `read_feather` and `read_parquet` restore the attributes of R as they were before they were written, so if we didn't write tibble to arrow file or parquet, it didn't become tibble, I think. That's right, they restore properties, but there was a little more going on here; sometimes we return a tibble and other times we return a `data.frame`, which isn't great. That was the original purpose of this PR - to fix that - but in fixing it, it became more complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
