ozankabak opened a new pull request, #5867: URL: https://github.com/apache/arrow-datafusion/pull/5867
# Which issue does this PR close? Takes a first step at addressing [this concern](https://github.com/apache/arrow-datafusion/pull/5661#discussion_r1148371213). # Rationale for this change Function signatures involving types related to expression ordering are starting to get overly verbose/complex. We would like to have simpler types/function signatures for readability and maintainability reasons. # What changes are included in this PR? We are introducing the following aliases: ```rust pub type ExprOrdering = Vec<PhysicalSortExpr>; pub type ExprOrderingRef<'a> = &'a [PhysicalSortExpr]; pub type OrderingRequirement = Vec<PhysicalSortRequirement>; ``` to simplify function signatures. If these aliases don't suffice in the future and we decide to use full-fledged types for this purpose, this PR will serve as a first step in that refactoring too. # Are these changes tested? Yes, all existing tests pass. # Are there any user-facing changes? Yes and no. Type-wise, nothing has changed (as these are type aliases). But a cursory look at traits and function signatures may give the impression that they have changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
