tustvold commented on code in PR #4019:
URL: https://github.com/apache/arrow-rs/pull/4019#discussion_r1157632904
##########
arrow-select/src/interleave.rs:
##########
@@ -193,7 +193,8 @@ fn interleave_fallback(
values: &[&dyn Array],
indices: &[(usize, usize)],
) -> Result<ArrayRef, ArrowError> {
- let arrays: Vec<_> = values.iter().map(|x| x.data()).collect();
+ let arrays: Vec<_> = values.iter().map(|x| x.to_data()).collect();
+ let arrays: Vec<_> = arrays.iter().collect();
Review Comment:
This is perhaps a little unfortunate, but given what this operation is
doing, it is not going to be relevant to the benchmarks, the machinery of
creating a MutableArrayData alone is likely more costly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
