kou commented on code in PR #34842: URL: https://github.com/apache/arrow/pull/34842#discussion_r1158069619
########## swift/Arrow/Tests/ArrowTests/testdata.arrow: ########## Review Comment: > Added the test data to the test as base64 encoded strings. It'll work for now but it will not work (too large data) when we have more supported patterns. How about `generate_test_data.py` or something and generating test data in test time? > We can remove this data and generate it once the FileWriter has been implemented? Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
